Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shell command execution on click for shell module #990

Closed
wants to merge 4 commits into from

Conversation

Dronte
Copy link

@Dronte Dronte commented Sep 12, 2023

Adding shell.left_click_command and shell.right_click_command to run commands upon clicking on the shell-module widget

@tobi-wan-kenobi
Copy link
Owner

There are generic "left-click" and "right-click" args for every module that should cover this functionality already.

Can you please give those a try?

@Dronte
Copy link
Author

Dronte commented Sep 12, 2023

Ah, yes that works... my bad

What do you think about adding this line to those? That speeds up label update.
https://github.com/tobi-wan-kenobi/bumblebee-status/pull/990/files#diff-8468fc6b35cfcdabccba415c8ef2dce3e768406f610d9b0f0137413c69bc0cc2R84

And do you find this useful?

https://github.com/tobi-wan-kenobi/bumblebee-status/pull/990/files#diff-f382f1f4b92c00b3b4fe465bcc2aaa3b85d110ce92833a49cb008bfc008c686bR58

@Dronte
Copy link
Author

Dronte commented Sep 12, 2023

Side question:
what do you think about same functionality for every widget in shortcut module?

@tobi-wan-kenobi
Copy link
Owner

I have added the two improvements you mentioned, I like them a lot, many thanks!

Regarding shortcut: @Dronte I don't think I follow, what do you mean? The additional call to "update"?

@Dronte
Copy link
Author

Dronte commented Sep 15, 2023

This is awesome, thanks for shipping it.

Sorry, I wasn't clear at all on the shortcut module, opened an issue, let's discuss it there?
#993

@Dronte Dronte closed this Sep 15, 2023
@Dronte Dronte deleted the dronte/shell-click branch September 15, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants