Bump Node version in package.json, re-generate package-lock.json #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `package-lock.json` file was generated with a now obsolete version of npm and any attempt to run `npm install` with a more recent version of npm starts with converting the file to the new JSON format. This update does this so that installing the code (or in a job) does not require creating changes to a repo file. The `package.json` file also referenced a now obsolete and no longer supported version of Node.js (v14). Using the opportunity to bump the versions to something more current (>v20.14 for Node, >v10.7 for npm). Any sufficiently recent install of Node.js will match these constraints, and this will allow using more advanced Node.js features (including `fetch` to replace the dependency on `request` down the road).
tidoust
changed the title
This was referenced Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
package-lock.jsonfile was generated with a now obsolete version of npm and any attempt to runnpm installwith a more recent version of npm starts with converting the file to the new JSON format. This update does this so that installing the code (or in a job) does not require creating changes to a repo file.The
package.jsonfile also referenced a now obsolete and no longer supported version of Node.js (v14). Using the opportunity to bump the versions to something more current (>v20.14 for Node, >v10.7 for npm). Any sufficiently recent install of Node.js will match these constraints, and this will allow using more advanced Node.js features (includingfetchto replace the dependency onrequestdown the road).@tobie, I do not know whether this can have any consequence on the server deployment. For the auto-update script, I'm going to create a PR right after this one to switch to a GitHub action, and that action actually needs the new version of
package-lock.json(otherwise it's going to update it itself...). I let you check for the web server.