Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18RoyalGorge] Prohibit train purchase when companies aren't connected #11364

Open
slapphappyjazz opened this issue Nov 19, 2024 · 1 comment · May be fixed by #11386
Open

[18RoyalGorge] Prohibit train purchase when companies aren't connected #11364

slapphappyjazz opened this issue Nov 19, 2024 · 1 comment · May be fixed by #11386
Assignees
@michaeljb
Labels
18RoyalGorge rules-broken Game comes to the wrong outcome compared with the rules (fixing these will break games)

Comments

@slapphappyjazz
Copy link

https://18xx.games/game/186716?action=256

At this point, 18xx.games is allowing SF to buy a train from SPP. This is not allowed under the rules because a company can only buy a train from another company if the two companies are connected.
@slapphappyjazz slapphappyjazz changed the title [18RoyalGorge] Prohibit train purchase when companies aren't connecte [18RoyalGorge] Prohibit train purchase when companies aren't connected Nov 19, 2024
@philcampeau philcampeau added rules-broken Game comes to the wrong outcome compared with the rules (fixing these will break games) 18RoyalGorge and removed needs triage labels Nov 19, 2024
@michaeljb michaeljb self-assigned this Dec 1, 2024
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Dec 1, 2024
@michaeljb
[18RoyalGorge] Require graph connection for cross-buying trains
a9b43d7 
From page 13 of 24 in the [current rulebook PDF][0].

Check for the connection when processing the action--instead of when finding
available trains to buy--to minimize the necessary graph checks.

Fixes tobymao#11364

[0]: https://boardgamegeek.com/filepage/284918/graphic-rulebook-preliminary
@michaeljb michaeljb linked a pull request Dec 1, 2024 that will close this issue
Open
4 tasks
@michaeljb
Copy link
Collaborator

#11386 will fix this, but the train from unconnected corporations will still be visible during the train buying step. If an attempt is made to purchase the train, the action will be canceled and an error message will appear.

Confirming that corporations are connected is computationally expensive, so it is only done after the fact when necessary, instead of when forming the list of available trains to buy for every single train buying step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeljb michaeljb

Labels
18RoyalGorge rules-broken Game comes to the wrong outcome compared with the rules (fixing these will break games)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[18RoyalGorge] Require graph connection for cross-buying trains michaeljb/18xx.games
3 participants
@michaeljb @philcampeau @slapphappyjazz