[18RoyalGorge] Require graph connection for cross-buying trains #11386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From page 13 of 24 in the [current rulebook PDF][0]. Check for the connection when processing the action--instead of when finding available trains to buy--to minimize the necessary graph checks. Fixes tobymao#11364 [0]: https://boardgamegeek.com/filepage/284918/graphic-rulebook-preliminary
This was referenced Dec 1, 2024
Open
ollybh
reviewed
Dec 15, 2024
| @@ -16,6 +16,21 @@ def room?(entity) | |||
| # even when train tight, there's room for a self-rust | |||
| return true if entity.trains.any? { |t| t.rusts_on == upcoming_train.name } | |||
| end | |||
|
|
|||
| def check_connected!(buyer, train) | |||
| return if train.owner == @game.depot | |||
There was a problem hiding this comment.
Adding a return if @game.loading guard cause here would remove the need for the game graph to be recalculated when a game is being loaded, at the cost of not rechecking the legality of the move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From page 13 of 24 in the current rulebook PDF.
Check for the connection when processing the action--instead of when finding available trains to buy--to minimize the necessary graph checks.
Fixes #11364
Pins needed: any games where an illegal (unconnected) cross-buy occurred.
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rake