[site] Discard Trains step to display page description instead of default 'Discard Trains' #11322
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philcampeau
changed the title
crericha
reviewed
Dec 15, 2024
| @@ -10,6 +10,10 @@ class DiscardTrain < Engine::Step::DiscardTrain | |||
| def process_discard_train(action) | |||
| @game.salvage_train(action.train) | |||
| end | |||
|
|
|||
| def description | |||
| 'Salvage Excess Trains' | |||
There was a problem hiding this comment.
The rulebook explicitly uses discard here.
Whenever trains are salvaged or discarded, the owning company receives the salvage value
If a phase change includes a reduction in the Train Limit [3], all companies, including the one
operating, must immediately discard any trains in excess of the Train Limit to the Bank Pool
for salvage value.
There was a problem hiding this comment.
It does, but is that the optimum phrasing?
There was a problem hiding this comment.
Since the site doesn't add the text "for salvage value", I feel this is an improvement.
There was a problem hiding this comment.
Salvage, as a verb, means to save something from destruction. So salvaging a train would be rescuing one from the scrap yard and putting it back into use, the opposite of what is happening here.
|
Throughout the rules of 18NY, and everywhere else in this game, salvaging is used to mean removing a train from a corp and receiving compensation. |
|
The use of salvage here means to turn something that is not so valuable (an
old train) into money that can be used to buy a new one. So the definition
still holds, if not in precisely the way Olly suggests. I suggest to stay
consistent with the rules usage.
…On Thu, Dec 19, 2024 at 1:32 PM philcampeau ***@***.***> wrote:
Throughout the rules of 18NY, and everywhere else in this game, salvaging
is used to mean removing a train from a corp and receiving compensation.
—
Reply to this email directly, view it on GitHub
<#11322 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6CEXBG7XDWGUAGWZ23HCT2GNJSJAVCNFSM6AAAAABRHOT7QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJVHE2TIMJQGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9128
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
This change, initially done for 18NY, will now allow all games to define what their Discard Trains step should display when prompting the discard of excess trains.
I also updated the description in lib/engine/step/discard_train.rb from 'Discard Train' to 'Discard Trains', since that's what was being displayed anyway.
Screenshots
Any Assumptions / Hacks
I know a previous fix (#9136) broke some things on the site. From the tests I've run on my end, these changes seem to work, but I'm happy to hear it if I'm wrong!