Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1860] fix player value in game variant #11340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philcampeau
Copy link
Collaborator

Fixes #11332

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

With the non_operated_full_value variant, when I modified the def player_value code, I forgot to add in the value of shares of corps with trains. Admittedly a big oversight!

I suspect we'll need to pin any finished games on that variant, since their recorded final scores will be incorrect.

Screenshots

Any Assumptions / Hacks

@philcampeau philcampeau added 1860 pins PR that will require some games to be pinned labels Nov 11, 2024
@roseundy
Copy link
Collaborator

@philcampeau - did the original change affect liquidity? If so, I'm not sure where that happened - but I'm at work and can't poke around the code very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1860 pins PR that will require some games to be pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1860 - player values and liquidity values glitch
2 participants