[18ESP] fix a few minor bugs #11393
[18ESP] fix a few minor bugs #11393
Conversation
lib/engine/game/g_18_esp/game.rb
Outdated
| token = corporation.tokens.first | ||
| hex = hex_by_id(corporation.coordinates) | ||
| city = hex.tile.cities.size > 1 ? city_by_id("#{hex.tile.id}-#{corporation.city}") : hex.tile.cities.first | ||
| city = if corporation_by_id('MZ')&.ipoed | ||
| # mza special case if mz already exists on the map |
There was a problem hiding this comment.
In general I think the corporation abbreviations in texts and comments should use upper case, so MZA and MZ in this case. Same comment for line 886.
| @@ -90,10 +90,14 @@ def choices | |||
| end | |||
|
|
|||
| def can_swap? | |||
There was a problem hiding this comment.
An alternative implementation could be to move line 95-97 plus the unless into a method that returns true/false.
And then
return true if is_some_method
followed by merged_token_in_shared_city? content.
Not sure which is most readable?
There was a problem hiding this comment.
i think this is readable as it is, i don't think refactoring will make it more readable
|
|
||
| transfer_amount = amount - 1 | ||
| @luxury_carriages['bank'] += transfer_amount | ||
| @luxury_carriages[owner] = 1 |
There was a problem hiding this comment.
Is this correct? I do not know the code so I might be wrong. Feels strange to set this to one here. Just checking.
There was a problem hiding this comment.
Yes, there is a private that comes with 5 tenders, but tenders can end up in the "bank"
other corps can buy tenders either from player owner of the private or the bank.
If private is bought in, all the tenders are transferred the the bank, except one which is owned by the corp buying the private in.
transfer all but one tender to the bank when buying p5.
fix broken game when buying p5
fix having two tokens in the same city when merging major with minor
Fixes #11337