Add "Auto pass" button in stock rounds.

[magnusrk-ch]

The button enables the auto pass in stock round program, same as the auto tab, but more accessible. The motivation is half to encourage more use of auto pass and half to make it less annoying when auto pass keeps getting cancelled over and over because someone sells and buys and sells and buys...

Only displayed for the active player, only in stock around, and does not show up in hotseat games.

[crericha-qualitrol]

I've seen a number of issues posted regarding auto pass not working properly. There are warnings about using it in the "Auto" tab, so I feel okay about the use at your own risk nature of the button there. Promoting the button to the main screen hides all those warnings.

I'm not necessarily opposed to the change, but I do think the above should be considered before pulling the trigger.

[crericha-qualitrol]

Or fix these issues first:
#5215
#6169
#6324
#6357
#6367

[magnusrk-ch]

My thinking here is that the button doesn't promise anything. It doesn't say "auto pass unless X, Y and Z" or link to details. The only way it can fail to meet expectations is by not passing. That's a safe way to fail, and also self-explaining (there's a comment in the log saying why it was cancelled).

In the case of someone who has read the auto tab and actually expects the automation to stop after shenanigans, they're no worse off with the new button than they were using the auto tab directly.

[crericha-qualitrol]

Take a look at the linked bugs. A few of them are related to auto pass passing when it shouldn't.

[crericha-qualitrol]

It does look like the warnings about using auto pass have been removed from the Auto menu. And I'm not saying don't promote the button to the main page. I'm saying think through if it is ready for that or if these bugs should be addressed first.

[scottredracecar]

I took a look at those issues and most of them are the autopass being overly conservative and turning itself off. The few that are most relevant/problematic are game specific, such as 1870 price protection. I support adding the button as is.

…

On Wed, Dec 1, 2021 at 12:56 PM Chris Rericha ***@***.***> wrote: It does look like the warnings about using auto pass have been removed from the Auto menu. And I'm not saying don't promote the button to the main page. I'm saying think through if it is ready for that or if these bugs should be addressed first. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG6CEXCKSES27W2DRC3QNJTUOZVU3ANCNFSM5JEL5MEQ> .

[tobymao]

i have no preference or opinion, @crericha-qualitrol i'll leave the decision to you

[crericha]

@magnusrk-ch, good comments on the issues I linked. Would you be able to fix #6169? If that one is resolved, I'd be okay with this PR.

[magnusrk-ch]

I've added a proposal for how to fix it, let's see if anyone has other opinions.

[jasonab]

There's also #6529 as an autopass issue

[magnusrk-ch]

#6583 and #6575 propose fixes for two of the above issues.