Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /tiles/test route to easily reference tiles from different titles and game states #9175

Merged
merged 4 commits into from
May 14, 2023

Conversation

michaeljb
Copy link
Collaborator

@michaeljb michaeljb commented May 11, 2023


Screenshot before fixtures finish processing:

loading

Done:

loaded

@michaeljb michaeljb added the tile rendering Parts on a tile/hex are rendering suboptimally; enhancement if currently playable, bug if broken label May 11, 2023
…ame states

* can display a tile as it appears on the board at any given point in any given
  fixture

    * fixtures are processed to the specified action, and the select tiles are
      rendered

* include tiles showing the problems reported in the following issues:

    * tobymao#4992

    * tobymao#5153

    * tobymao#5167

    * tobymao#5673

        * copy 18Mag fixture 76622 to a new fixture to reproduce

    * tobymao#5981

    * tobymao#6604

    * tobymao#7765

    * tobymao#8178

* add completed 1868 Wyoming game as a fixture

    * 1846 and 1868 Wyoming tiles added here were used for the before/after
      screenshots in tobymao#9174

* move fixtures from `/spec/fixtures/` into `/public/fixtures/` so the JSON can
  be accessed via `/fixtures/<title>/<fixture_id>.json`

* test cases defined in a location accessible by both the view code and server
  side code (`lib/engine/test_tiles.rb`) so that when the page is initially
  served up, it already includes the `<script>` tags for the games being tested

    * test cases need a `title`, can also have `title`, `fixture`, `action`, and
      any `kwargs` used by `render_tile_blocks`
@michaeljb michaeljb merged commit 7f38749 into tobymao:master May 14, 2023
@michaeljb michaeljb deleted the tiles-test-page branch May 14, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tile rendering Parts on a tile/hex are rendering suboptimally; enhancement if currently playable, bug if broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants