Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): should not show context menu if there is no typos #8895

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 22, 2024

fix AF-1794

Copy link

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Nov 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the app:electron Related to electron app label Nov 22, 2024
@pengx17 pengx17 marked this pull request as ready for review November 22, 2024 07:55
Copy link

nx-cloud bot commented Nov 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c078ae8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (c6ac426) to head (c078ae8).
Report is 7 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8895      +/-   ##
==========================================
- Coverage   70.86%   70.19%   -0.67%     
==========================================
  Files         550      550              
  Lines       33980    34005      +25     
  Branches     3089     3052      -37     
==========================================
- Hits        24081    23871     -210     
- Misses       9524     9762     +238     
+ Partials      375      372       -3     
Flag Coverage Δ
server-test 77.07% <ø> (-0.79%) ⬇️
unittest 46.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant