Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfct/API endpoints for state exploration #47

Open
wants to merge 6 commits into
base: refactor
Choose a base branch
from
Open

Conversation

kaiden-araki
Copy link
Collaborator

@kaiden-araki kaiden-araki commented Jan 15, 2025

Remove api module

  • Remove api module except stateAPIUpdater
  • Remove the code which was already commented out after confirmation

@kaiden-araki kaiden-araki self-assigned this Jan 15, 2025
// }

// // Add explorer endpoints
// if setup.ExplorerEndpoints {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to create api server and attach these endpoints for explorers. Just leaving the stateapiupdater package doesn't mean anything because the state is currently not being exposed. Here is an explanation from the stateapiupdater package:

/*
Package stateapiupdater is responsible for generating and storing the object response of the 
GET /state endpoint exposed through the api package.
*/

@kaiden-araki kaiden-araki changed the title rfct/remove api module rfct/API endpoints for state exploration Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants