Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Navigator #603
base: master
Are you sure you want to change the base?
Graph Navigator #603
Changes from 16 commits
c7828e7
50652df
4e266e1
0eff226
52b3447
e9c7f66
0f39937
24cec3d
b994acc
5a4e5e6
242fe67
c0e6a98
1e024af
c373a86
8ce784d
e2289c0
ca62fba
f5e35f4
ee5810d
327c0f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how we can get this type out of
packages/graph-engine/src/nodes/generic/subgraph.ts
so we can do a proper typescript type check.I would have liked to do a check like
but I'm not sure how importing for types/classes works for such packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NextJS was erroring because there's a circular dependency.
I think this is not too bad if we have some interface for global methods.