Remove work around for Android simulator #1798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jshearer any chance to can confirm this has been fixed on Android's side? |
Use accept4 instead.
Thomasdezeeuw
force-pushed
the
remove-android-workaround
branch
from
f5616fd
to
4e4f913
Compare
|
I'm unable to find any evidence that this has been fixed. I could run it in an emulator to test, but even if it works on the emulator I know how to use, that does not mean that it also works on older versions of Android (mio supports back to API level 21). I recommend not making this change at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use accept4 instead.
Updates #1445