Task poll callbacks #7120
Merged
Task poll callbacks #7120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
R-loom-current-thread
GJason88
force-pushed
the
task-poll-callbacks
branch
2 times, most recently
from
3491a25 to
f1a7c83
Compare
maminrayej
added
A-tokio
GJason88
force-pushed
the
task-poll-callbacks
branch
from
f1a7c83 to
404d496
Compare
added 7 commits
January 23, 2025 18:32
GJason88
force-pushed
the
task-poll-callbacks
branch
from
404d496 to
d761c88
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iteration on #7107
Discussion was had on discord.
current_threadruntime (factored out callback logic toTaskHooks).multi_threadpoll_start_callbackcall to be directly beforetask.run().#[cfg(tokio_unstable)]to the rest of the implementation.task_id. Talked about potentially adding test for any edge cases regarding LIFO.Looking to bikeshed on naming.
Motivation
We would like to be able to store metadata before polls start and stop to allow us to instrument all polls, not just polls where you have spawned the task.
Solution
Add callbacks for poll start and stop