-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring (WIP) #1
Open
StefanGreve
wants to merge
25
commits into
tolik518:master
Choose a base branch
from
StefanGreve:refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable DI in startup code * Implement a SerializerFactory to deduce the appropriate serialization implementation * Configure logging and app settings * Edit csproj: add release build configuration
* set default format option (csharp) * improve error handling in SerializerService
StefanGreve
commented
Mar 13, 2024
StefanGreve
commented
Mar 13, 2024
StefanGreve
commented
Mar 13, 2024
StefanGreve
commented
Mar 13, 2024
* add placeholder file for Python serializer * add encoding option to appsettings.json * validate AppSettings on startup fluently
c4f4a86
to
00de5ef
Compare
* since there is no way to overwrite the default top-level comment, we have to create a helper function to replace the default text at the top of the automatically generated code
00de5ef
to
b4bdc36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
CSharpSerializer
IniSerializer
JsonSerializer
PhpSerializer
PythonSerializer
RustSerializer
appsettings.json
README.md