Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin specific versions of Folly's clang deps #823

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

bkirwi
Copy link

@bkirwi bkirwi commented Jan 9, 2024

While poking at bkirwi/folly#2, I noticed that Ubuntu Debian ships multiple versioned packages of clang, so it's actually relatively straightforward to switch back to a compatible version.

I'll still work to get a version of the ML runtime that's compatible with the cutting edge, so things don't bitrot forever and to justify the fairly large amount of time I've already spent, but this should unbreak things in the meantime.

@Eeems
Copy link
Member

Eeems commented Jan 9, 2024

Ubuntu

We actually use debian as the base for the toolchain images.

@Eeems Eeems added bug Something isn't working packages Add or improve packages of the repository labels Jan 9, 2024
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the version number to force a rebuild. Just change it from -3 to -4

@Eeems Eeems added this to the 2024-W03 Merge Window milestone Jan 9, 2024
@Eeems Eeems linked an issue Jan 9, 2024 that may be closed by this pull request
@bkirwi
Copy link
Author

bkirwi commented Jan 10, 2024

Updated with the requested changes!

Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I opened a couple non-blocking (and one unrelated) issues on the folly repo for you to look at eventually.

Edit: I'm also very surprised at how well it's able to interpret my chicken scratch.

@bkirwi bkirwi merged commit 4f06523 into toltec-dev:testing Jan 11, 2024
3 checks passed
Eeems pushed a commit that referenced this pull request Jan 28, 2024
* Pin specific versions of folly's clang deps

* Bump version
Eeems added a commit that referenced this pull request May 21, 2024
### New Packages
- `move-logs-to-opt` - 0.0.1-1 (#821)
  - Move log files to `/opt` to avoid filling up the root partition.
- `oxide-extra` and `liboxide-dev` - 2.7-3 (#760)

### Updated Packages
- `folly` - 0.0.1-4 (#823)
- `koreader` - 2024.01-1 (#826)
- `linux-stracciatella` - 5.4.70.4-1 (#808)
- `oxide`,  `oxide-utils`, `inject_evdev`, and `liboxide` - 2.7-3 (#760)
- `puzzles` - 0.2.4-4 (#785)
- `rm2-suspend-fix` - 0.0.0-3 (#821)
- `genie` - 0.1.7-1 (#825)
- `harmony` - 0.2.3-1 (#825)
- `iago` - 0.1.2-1 (#825)
- `remux` - 0.3.0-1 (#825)
- `simple` - 0.2.1-1 (#825)
- `tilem` - 0.1.1-1 (#764)
- `toltec-base` - 1.3-1 (#806)
- `yaft` - 0.1.1 (#763)
- `zoneinfo-utils` - 2023c-1 (#702)
- `rmfakecloud-proxy` - 0.0.3-5 (#757 #831)

### Packages removed
- `erode`, `tarnish`, `decay`, and `corrupt`
  - Replaced by `oxide`
- `fret`, and `anxiety`
  - Replaced by `oxide-extra`
- `rot`
  - Replaced by `oxide-utils`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folly build broken
2 participants