Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do all HTTP streaming through Tomahawk #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theli-ua
Copy link
Contributor

@theli-ua theli-ua commented May 8, 2015

For consistency and better control.
Currently if resolver returns direct http link - they go as is to VLC, if resolver returns custom scheme link (tidal://) but later in geturlstream handler returns http link - it goes through Tomahawk+imem

@xhochy
Copy link
Member

xhochy commented May 8, 2015

We were thinking of this since a long time but there were some issues because of which I did not want to make the switch. The most important one was that seeking with at least Spotify did not really work with our builtin imem-http layer.

@theli-ua
Copy link
Contributor Author

theli-ua commented May 8, 2015

Then make all http links passthrough to vlc. You shouldn't be half here and half there. You have to be at least consistent. And I know imem has seeking problems, in fact it doesn't even support seeking natively. With imem flac seeking in TIDAL doesn't work for example.

@muesli
Copy link
Member

muesli commented May 8, 2015

That's not an option because we then can't accept self-signed certificates for resolvers like subsonic/ampache/owncloud.

@theli-ua
Copy link
Contributor Author

theli-ua commented May 8, 2015

@muesli I said HTTP not HTTPS, as I was explaining its inconsistend atm - if resolver will set track URL to http link - it is passthroughed to vlc, but if resolver returns something like tidal://trackID and later resolves that to http - it goes through imem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants