Merge branch '4.0' into matyus/semantic-versions

tomaj · Apr 19, 2024 · abb3062 · abb3062
2 parents 7c8f389 + 97718ff
commit abb3062
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
 ## [Unreleased][unreleased]
 #### Changed
 * [BC] Support for semantic versioning api. Need retype version from `int` to `string`.
+* [BC] DefaultHandler response code 404 instead 400
 
 #### Added
 * CorsPreflightHandlerInterface - resolve multiple service registered handler error

diff --git a/src/Handlers/DefaultHandler.php b/src/Handlers/DefaultHandler.php
@@ -15,6 +15,6 @@ class DefaultHandler extends BaseHandler
      */
     public function handle(array $params): ResponseInterface
     {
-        return new JsonApiResponse(IResponse::S400_BAD_REQUEST, ['status' => 'error', 'message' => 'Unknown api endpoint']);
+        return new JsonApiResponse(IResponse::S404_NOT_FOUND, ['status' => 'error', 'message' => 'Unknown api endpoint']);
     }
 }
diff --git a/tests/Handler/DefaultHandlerTest.php b/tests/Handler/DefaultHandlerTest.php
@@ -18,7 +18,7 @@ public function testResponse()
     {
         $defaultHandler = new DefaultHandler();
         $result = $defaultHandler->handle([]);
-        $this->assertEquals(400, $result->getCode());
+        $this->assertEquals(404, $result->getCode());
         $this->assertEquals('application/json', $result->getContentType());
         $this->assertEquals('utf-8', $result->getCharset());
         $this->assertEquals(['status' => 'error', 'message' => 'Unknown api endpoint'], $result->getPayload());