Add application/hal+json content-type support #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found out that the HAL media type extension to JSON
content-type: application/hal+jsonis not currently supported on Needle.https://www.innoq.com/en/articles/2020/12/rest-apis-with-hal/
I would like to propose with this PR to manage application/hal+json parsing it as JSON.
I added a test as well to check this new content-type capability.
I managed to execute tests via docker and I would like to propose to modify the docker command line on the README file, in order to directly run the container and being able to execute npm tests afterwards.
Please let me know if you have any questions or remarks.
Many thanks,
Loïc