Fix tests #21

emlyn · 2021-08-09T19:49:07Z

The tests fail with:

 FAIL  src/db/guitar.test.js (11.684s)
  ● Guitar Chords › Key F › Suffix Fmajor › Positions › Fingers › The 2 position fingers array should have values higher or equal to 0

    expect(received).toBeGreaterThanOrEqual(expected)

    Expected: >= 0
    Received:    -1

Looking at the other chords it looks like fingers should contain 0s instead of xs.

The tests fail with: ``` FAIL src/db/guitar.test.js (11.684s) ● Guitar Chords › Key F › Suffix Fmajor › Positions › Fingers › The 2 position fingers array should have values higher or equal to 0 ``` Looking at the other chords it looks like `fingers` should contain `0`s instead of `x`s.

sircris

Looks good @emlyn

sircris · 2023-02-24T01:02:42Z

src/db/guitar/chords/F/major.js

@@ -10,7 +10,7 @@ export default {
    },
    {
      frets: 'xx3211',
-      fingers: 'xx3211',
+      fingers: '003211',


@emlyn nice fix. @tombatossals, can you incorporate this update so that the test on the master branch code can succeed? I did verify that it does work properly after this change is in place.

sircris approved these changes Feb 24, 2023

View reviewed changes

jonbae mentioned this pull request Aug 31, 2023

fix f major fingering #27

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix tests #21

Fix tests #21

emlyn commented Aug 9, 2021

sircris left a comment

sircris Feb 24, 2023

Fix tests #21

Are you sure you want to change the base?

Fix tests #21

Conversation

emlyn commented Aug 9, 2021

sircris left a comment

Choose a reason for hiding this comment

sircris Feb 24, 2023

Choose a reason for hiding this comment