Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Do Not Disturb #50

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

kevinold
Copy link

Add "Enable Do Not Disturb during Pomodoro" option under Notifications

Enables toggling the Do Not Disturb option in Notification Center.

Enables DND when Pomodoro timer starts
Disables DND when Pomodoro timer completes

screen shot 2018-03-16 at 4 53 11 pm

This implementation should satisfy #45, but I would appreciate feedback.

CC @mtavkhelidze @ccidral @dvntucker @dzindra

@mtavkhelidze
Copy link
Contributor

Looks! The only thing is that UI window lookes a bit skewed.

@felipeng
Copy link

Looking forward for this feature

@danilokleber
Copy link

I would love to see this merged. Is @dvntucker or another maintainer still around to accept it?

@mtavkhelidze
Copy link
Contributor

Please, Squash-Merge it.

@ccidral
Copy link
Member

ccidral commented Feb 17, 2021

Sorry guys I'll try to find some time to merge this PR this week but I can't promise anything.

@kevinold
Copy link
Author

I can try to bring it up to date if needed. I'd love to have this in officially

@ccidral
Copy link
Member

ccidral commented Feb 17, 2021

@kevinold Thanks so much, that would be wonderful. I'll do my best to commit to a date to review and merge your PR. I'd say Feb 21st 🤞🏻

@danilokleber
Copy link

Guys, could I help with getting this released?

@danilokleber
Copy link

@ccidral, there's nothing we can do to get this merged? Sorry for the noise.

@ccidral
Copy link
Member

ccidral commented Dec 9, 2021

It's been forever since I last played with native MacOS apps, so it would probably take forever for me to setup everything and test this PR. If anyone can verify that this PR is building and working properly, I'll take your word for it and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants