Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show remaining time in status bar and more #6

Closed
wants to merge 15 commits into from
Closed

Show remaining time in status bar and more #6

wants to merge 15 commits into from

Conversation

dzindra
Copy link
Contributor

@dzindra dzindra commented Mar 5, 2014

Just made few modifications that show remaining time in status bar (as requested in #1) and added ability to pause timer (as requested in #2).

This PR is based on @oleksii-taran's version of the repo (and is effectively including all his commits too).

@ccidral
Copy link
Member

ccidral commented Mar 6, 2014

Awesome! I'm going to check it out.

@dzindra
Copy link
Contributor Author

dzindra commented Mar 7, 2014

Any news on checking? I have some more ideas for new features like automatic switching between pomodoros and breaks :)

@ccidral
Copy link
Member

ccidral commented Mar 11, 2014

Hi @dzindra. Please standby, I'm rewriting the project from scratch because the current design is a bit 'rigid'. The new design is based on an event bus, which I hope will make it a lot easier to modify and add new features.

@grmiguel
Copy link

I also was thinking about making it to switch automatically between pomodoros and breaks :). Can't wait for that rewritten version, @ccidral !

@ccidral
Copy link
Member

ccidral commented Mar 11, 2014

@grmiguel Great, that should be much easier to do with the new design. Stay tuned.

@ccidral
Copy link
Member

ccidral commented Mar 13, 2014

Hey guys, I just pushed the newly rewritten project (39017a4). Please take a look at it and tell me what you think. Now there's an event bus that components use to be notified about specific events, like timer events or changes on preferences. Also, almost everything is now covered by unit tests.

Questions, suggestions and critics on anything related to code and design are welcome. I'm a newbie when it comes down to Objective C and OSX programming, so please forgive me if you find something bizarre in the source code. Let me know (or make a pull request) if you stumble upon something odd.

I'm closing this pull request since @dzindra agreed to port his changes manually to the new version.

@ccidral ccidral closed this Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants