Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: perf commit triggers patch release #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: perf commit triggers patch release #25

wants to merge 1 commit into from

Conversation

hannesvanhove-tomtom
Copy link

No description provided.

jstmlr
jstmlr requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@jstmlr jstmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but anything other than fix bumping the patch version can never be default behavior.

If the functionality to add additional patch-bumping type tags is required, it will have to be configurable from the CLI (e.g. --additional-patch-bump-types).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstmlr jstmlr jstmlr requested changes

@KevinDeJong-TomTom KevinDeJong-TomTom Awaiting requested review from KevinDeJong-TomTom KevinDeJong-TomTom is a code owner

@muggenhor muggenhor Awaiting requested review from muggenhor muggenhor is a code owner

@maikelvdh maikelvdh Awaiting requested review from maikelvdh maikelvdh is a code owner

@MartijnLeijssen-TomTom MartijnLeijssen-TomTom Awaiting requested review from MartijnLeijssen-TomTom MartijnLeijssen-TomTom is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannesvanhove-tomtom @jstmlr