Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate BasicNavigation to Compose #90

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hgarciaalberto
Copy link

This PR has been done in top of the previous PR #89, it also includes its changes.
This Pull Request implements an example of TomTom's SDK integration in Compose using interoperability libraries.

@AristotelispetrosBobas-TomTom
Copy link
Collaborator

Hi @hgarciaalberto,

Thanks for your contribution.

Please see my reply in the other PR.

As far as migrating to Compose, we can have a closer look at this after our deployment restructuring has concluded.

@hgarciaalberto hgarciaalberto force-pushed the feature/migrate-navigation-to-compose branch from 470ed75 to adf87d9 Compare January 24, 2024 15:31
@hgarciaalberto
Copy link
Author

Hi @AristotelispetrosBobas-TomTom , I've checked the preview branch and found that it's a bit outdated. Therefore, I've decided to rebase this branch to main instead.
Additionally, I have updated the code to the latest dependency versions and adapted it to compose.
If anyone from TomTom could continue adapting the project and provide good practices for the migration, it would be greatly appreciated.

@@ -415,8 +415,9 @@ class MainActivity : AppCompatActivity() {
* Set the bottom padding on the map. The padding sets a safe area of the MapView in which user interaction is not received. It is used to uncover the chevron in the navigation panel.
*/
private fun setMapNavigationPadding() {
val paddingBottom = resources.getDimensionPixelOffset(R.dimen.map_padding_bottom)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AristotelispetrosBobas-TomTom, can you have a look at this, I think it is a potential error because the chevron doesn't appear on the screen. Can you double check that?

@hgarciaalberto hgarciaalberto force-pushed the feature/migrate-navigation-to-compose branch from 38d7dc5 to ad09728 Compare February 2, 2024 19:25
@hgarciaalberto hgarciaalberto force-pushed the feature/migrate-navigation-to-compose branch from ad09728 to 08bda75 Compare February 15, 2024 10:49
@hgarciaalberto hgarciaalberto force-pushed the feature/migrate-navigation-to-compose branch from 08bda75 to 9cb20cc Compare March 29, 2024 15:52
@hgarciaalberto hgarciaalberto force-pushed the feature/migrate-navigation-to-compose branch from 9cb20cc to c135704 Compare July 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants