-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate BasicNavigation to Compose #90
base: main
Are you sure you want to change the base?
Migrate BasicNavigation to Compose #90
Conversation
Hi @hgarciaalberto, Thanks for your contribution. Please see my reply in the other PR. As far as migrating to |
470ed75
to
adf87d9
Compare
Hi @AristotelispetrosBobas-TomTom , I've checked the preview branch and found that it's a bit outdated. Therefore, I've decided to rebase this branch to main instead. |
@@ -415,8 +415,9 @@ class MainActivity : AppCompatActivity() { | |||
* Set the bottom padding on the map. The padding sets a safe area of the MapView in which user interaction is not received. It is used to uncover the chevron in the navigation panel. | |||
*/ | |||
private fun setMapNavigationPadding() { | |||
val paddingBottom = resources.getDimensionPixelOffset(R.dimen.map_padding_bottom) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AristotelispetrosBobas-TomTom, can you have a look at this, I think it is a potential error because the chevron doesn't appear on the screen. Can you double check that?
38d7dc5
to
ad09728
Compare
ad09728
to
08bda75
Compare
08bda75
to
9cb20cc
Compare
9cb20cc
to
c135704
Compare
This PR has been done in top of the previous PR #89, it also includes its changes.
This Pull Request implements an example of TomTom's SDK integration in Compose using interoperability libraries.