#patch install dotenv

.env-development

@@ -0,0 +1,2 @@
+NODE_ENV=development
+BACKEND_BASE_URL=https://api.themoviedb.org

.github/workflows/build-and-deploy-to-scaleway.yaml

@@ -35,7 +35,7 @@ jobs:
 
       - run: npm run build
         env:
-          BACKEND_BASE_URL: ''
+          BACKEND_BASE_URL: 'https://api.themoviedb.org'
           STATIC_FILES_URL: 'https://reacteasyssrjckf9fbl-reacteasyssrstatic.functions.fnc.fr-par.scw.cloud'
 
       - name: Copy past client static files

README.md

@@ -59,6 +59,12 @@ it's gonna use the `.nvmrc` file with v16.20.0
 
 ### Start in dev mode
 
+Get prepared with the env vars
+
+```sh
+cp .env-development .env
+```
+
 ```npm
 npm install
 ```

package.json

@@ -41,6 +41,7 @@
     "compression-webpack-plugin": "^10.0.0",
     "core-js": "^3.25.3",
     "cors": "^2.8.5",
+    "dotenv": "^16.3.1",
     "express": "^4.18.2",
     "global": "^4.4.0",
     "isomorphic-fetch": "^3.0.0",

src/store/reducers/index.ts

@@ -54,15 +54,10 @@ const movies = (state = INITIAL_STATE_MOVIES, action: ActionDispatch) => {
       }
     case ActionTypes.MOVIES.SUCCESS:
       delete copyState.error
-      // eslint-disable-next-line no-case-declarations
-      let data: unknown = []
-      if (action.body.dispatchKind === 'GET_MOVIES') {
-        data = action.response?.results
-      }
       return {
         ...copyState,
         isLoading: false,
-        data
+        ...(action.body.dispatchKind === 'GET_MOVIES' && { data: action.response.results })
       }
     case ActionTypes.MOVIES.FAILURE:
       return {

webpack/index.js

@@ -1,9 +1,8 @@
+require('dotenv').config()
+
 module.exports = (env) => {
-  process.env.BACKEND_BASE_URL = 'https://api.themoviedb.org'
   if (typeof env !== 'undefined' && env === 'development') {
-    process.env.NODE_ENV = 'development'
     return [require('./webpack.client.dev'), require('./webpack.server.dev')]
   }
-  process.env.NODE_ENV = 'production'
   return [require('./webpack.client.prod'), require('./webpack.server.prod')]
 }