Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI parameters for disable/enable peer #248

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

linuskendall
Copy link
Contributor

Adds a --name parameter and --yes parameter to the enable-peer/disable-peer. Helps with large network management where we need some automated tools to disable/enable peers.

Fixes #214.

Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for your contribution! Added just one supernit/question.

I'd wait a couple of days to that others also have an opportunity to review, but then this is good for merging from me.

shared/src/prompts.rs Outdated Show resolved Hide resolved
Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, thanks for the PR! I think this is good to merge after following up on the clarifying questions.

@linuskendall
Copy link
Contributor Author

Overall this looks good, thanks for the PR! I think this is good to merge after following up on the clarifying questions.

Thanks for the quick review - I have been travelogn but will take a look and address the comments next week.

@l4l
Copy link

l4l commented Dec 3, 2023

Any chance for this being merged soon?

@linuskendall
Copy link
Contributor Author

Overall this looks good, thanks for the PR! I think this is good to merge after following up on the clarifying questions.

Sorry for leaving this dangling for so long! I just lost of track of it. Updated as per the comments.

Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks, @linuskendall! Good to merge, though would be good to test in real life first.

Want anyone in the community to quickly test? Ideally both the server and client variants of the new options.

@linuskendall
Copy link
Contributor Author

linuskendall commented Dec 13, 2023 via email

@goodhoko
Copy link
Member

@strohel Taking you attention back to this. I think this could me deemed as tested. Can we merge?

@strohel strohel merged commit aa1ac51 into tonarino:main Jan 15, 2024
5 checks passed
@strohel
Copy link
Member

strohel commented Jan 15, 2024

Thanks for ping, I've hit the merge button. Thanks everybody contributing ans sorry for the delays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add name flag to disable-peer command
5 participants