Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker tests #282

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Fix docker tests #282

merged 2 commits into from
Aug 23, 2023

Conversation

mcginty
Copy link
Collaborator

@mcginty mcginty commented Aug 22, 2023

At some point, the golang and rustlang docker images decided that latest meant different things. Golang was building on the new bookworm Debian version, while Rust wasn't. This forces them both to a specific version of Debian to avoid glibc conflicts.

Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good to have the nicer test output too.

Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks for fixing the CI @mcginty! Yay!

@strohel strohel merged commit 376ab64 into main Aug 23, 2023
5 checks passed
@strohel strohel deleted the mcginty/fix-docker-tests branch August 23, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants