Add tests for models in the core app #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modify the dataset model with a __str__ return - modify .gitignore by adding env folders
- add model bakery to requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds tests specifically for models in the core app of this project. The functionality targeted specifically is all models in the core app.
Contributes to resolving issue: hotosm#229
Considerations
I added string representations to the models to provide an easier to read human readable value when a model instance is queried.
I also modified the .gitignore to include .venv and .env folder to avoid accidentally committing those types of files.
While writing the tests I came across a model simply named Model which seems redundant and confusing. This should be changed to a name that fits the functionality better.
I realized that there's a lot of boilerplate while writing the tests and decided to use ModelBakery to modify the tests.
Some warnings pop up when running the tests in regards to how the auto field has been used for dates. They don't stop tests or the project from running but modifications can be made to the relevant fields to remove the warning:
How to test?
The test for the models in the core app can be run with
python manage.py test tests.test_models_core.