-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only analyze files that are children of the targets in build() #225
Open
devdanzin
wants to merge
18
commits into
tonybaloney:master
Choose a base branch
from
devdanzin:build_target_children
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 95.86% 94.81% -1.06%
==========================================
Files 25 25
Lines 1403 1407 +4
Branches 296 297 +1
==========================================
- Hits 1345 1334 -11
- Misses 33 48 +15
Partials 25 25 ☔ View full report in Codecov by Sentry. |
…drive than C:, take 2.
… drives in Windows.
…ether a target is a descendant of config.path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building, wily creates lists of target files to scan based on added and modified files from the git repository. It's possible to pass a path to
wily build
, but it won't currently avoid scanning files outside of the path.This PR makes wily only scan files that are children of the chosen path during build. This is an improvement for building in repositories that contains large files that aren't interesting to analyze. The behavior remains unchanged if no path is passed to
wily build
.This addresses a TODO in build.py, adapting some commented out code:
wily/src/wily/commands/build.py
Line 103 in 2590691