Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestJS v10 support #207

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EdgarHarutyunyan02
Copy link

@EdgarHarutyunyan02 EdgarHarutyunyan02 commented Oct 20, 2023

Hi all,

With these changes I'm adding support for NestJS v10 which was released in June 2023.

Recently NodeJS v20 transitioned to LTS status, so added that in the supported engines as well.
Updated the CircleCI config to include these new versions as well.

Besides the integration tests I also tested it locally on a NestJS v10 project running with Node v20 and it worked as expected.

Add support for NestJS10 by extending the peer dependencies, add support for NodeJS v20
@EdgarHarutyunyan02 EdgarHarutyunyan02 changed the title Nestjs 10 support NestJS v10 support Oct 20, 2023
Updated ci to test with new versions of NestJS and Node v20
@EdgarHarutyunyan02
Copy link
Author

Hi @toondaey. Please let me know if there is anything missing.

@toondaey
Copy link
Owner

Hi @toondaey. Please let me know if there is anything missing.

Thanks for the contribution @EdgarHarutyunyan02 ! I'm sorry for the late response. I'll need some time to make some changes to the entire package. Have some plans but haven't had time to look into it.

@EdgarHarutyunyan02
Copy link
Author

Hi @toondaey, is it going to be a whole refactor?

@toondaey
Copy link
Owner

toondaey commented Nov 2, 2023

Hi @toondaey, is it going to be a whole refactor?

Not essentially. Just to update how the way the package is published to npm. I've had to do it manually ever since I wrote the package.

@EdgarHarutyunyan02
Copy link
Author

EdgarHarutyunyan02 commented Nov 2, 2023

Hi @toondaey, is it going to be a whole refactor?

Not essentially. Just to update how the way the package is published to npm. I've had to do it manually ever since I wrote the package.

Ok, that's fine.
Just FYI, I'll create an override in my app's package.json to unblock this situation.

  "overrides": {
    "@t00nday/nestjs-got": {
      "@nestjs/common": "$@nestjs/common"
    }
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants