Sub tab next cases #10
Conversation
| ADD_EMPLOYEE = 'Add Employee' | ||
| } | ||
|
|
||
| export enum Labels { |
There was a problem hiding this comment.
It's generally recommended to name enums in a singular way. So it would be Label instead of Labels. This reflects that each constant within the enum (like USERNAME, PASSWORD, LOGIN, etc.) represents a single, distinct label. This singular naming convention makes the code more intuitive and easier to understand, especially for other developers who might work with it in the future.
There was a problem hiding this comment.
right when we use it lebel.specific_label then it is one lebel not more
| return this.page.getByText(Labels.EDIT_POST); | ||
| } | ||
|
|
||
| protected getDletePostButton( |
| } | ||
|
|
||
| public getCommentInput( | ||
| randomTitle: string |
There was a problem hiding this comment.
I would probably not name this randomTitle but just title. The place where you call this function does not use randomTitle. Even if it would be random from the callers perspective - still using "title" as name makes more sense. Because if you would just pass not a random title, then the parameters name would be more generic.
| // public getPostWithRandomTitleWithoutPhoto(randomTitle: string): Locator { | ||
| // return this.page.locator(`.orangehrm-buzz-post-body:has(:text("${randomTitle}")) .orangehrm-buzz-post-body-text`); | ||
| // } | ||
| // this also works, let's keep it in codebase for poor times |
There was a problem hiding this comment.
poor times means times when we do not know how to do something then we will have 2 soluation maybe in different code only 1 of them will work so i would keep it in code
| ): Locator { | ||
| return this.page | ||
| .getByText(randomNewEmployeeName) | ||
| .locator("xpath=../..") |
There was a problem hiding this comment.
In this particular case, ../.. is an XPath expression used to select the parent of the parent element. It's essentially asking Playwright to locate an element's grandparent. This could be useful when you want to select an element relative to its grandparent in the HTML structure.
src/test/functional/pages/PimPage.ts
Outdated
| firstRandomName: string, | ||
| bySubtub?: boolean | null | ||
| ) { | ||
| if (bySubtub === true) { |
src/test/functional/pages/PimPage.ts
Outdated
| await this.searchEmployeeButton.click() | ||
| public async addEmployeeWithLoginDetails( | ||
| firstRandomName: string, | ||
| bySubtub?: boolean | null |
There was a problem hiding this comment.
You created an union type here which is boolean | null - do you need null here?
| public async searchEmployeeById(employeeId:string) { | ||
| await this.employeeIdInput.type(employeeId) | ||
| await this.searchEmployeeButton.click() | ||
| public async addEmployeeWithLoginDetails( |
There was a problem hiding this comment.
"...LoginCredentails" instead of "LoginDetails"? More accurate, but you choice ;)
| await expect(page.locator(tableCells[0])).toBeVisible(); | ||
| await expect(page.locator(tableCells[1])).toBeVisible() | ||
| }) | ||
| test("Admin user should edit previousely created employee with random name", async ({ |
There was a problem hiding this comment.
I think the title is confusing. Why "random name"? I think you know already which employee you have been created, so it is not random anymore ;) I suggest to remove word "random"
There was a problem hiding this comment.
and in general, for all method's name - why you always write get...byRANDOM...? why Random? I know that you generated ranom name, but it is confusing. Of course MINOR comment
No description provided.