Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user test #5
base: 5.5
Are you sure you want to change the base?
Add user test #5
Changes from 13 commits
3c53d96
752894d
b7bed5c
6258d9d
3f30c79
5a8e2a2
28ff6d5
4718915
a12e2f9
3651773
f4fadbc
256df30
11405ec
dcadf5d
52a17f7
9451fd2
d608e1c
7651417
9d56eb7
85f2701
f6ae562
098441c
497bc4e
6f3da2b
518ceb2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not very useful...
await expect(somePageThatIUseInTest.pageHeader).toBeVisible();
is very readable and doesn't need wrapping IMOThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't be needed after adding getTextboxByTextLabel method to BasePage (and extending it by this class)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't be needed after adding getTextboxByTextLabel method to BasePage (and extending it by this class).
And - nth is not a proper way to define Locators.
If layout will change and another field will be added between some fields, test most probably will go with no problem, but the data will land in another field instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wraping this isn't very useful, especially if option is pretty generic, but well... I get it somehow... please use exact: true in options and perhaps move it to BasePage instead?
then it can be public (because it would possibly be used by tests) or protected if you're not planning to use it in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well... clickCheckbox that accepts 'span' as a locator?
Please consider to create BasePage universal method similar to getTextboxByTextLabel (mentioned earlier) - I quess all theirs checkboxes are toggles so to avoid confusion you can name it
getToggleByTextlLabel(textLabel: string)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use getTextboxByTextLabel mentioned earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use getTextboxByTextLabel mentioned earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see fillPersonalDetails comment and do similarly (you can even use the same UserData type)
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.