feat: don't add configmap volumemounts in wait container(argoproj#13089)

tooptoop4 · May 25, 2024 · 8fc54ab · 8fc54ab
1 parent 4d8f972
commit 8fc54ab
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/workflow/controller/workflowpod.go b/workflow/controller/workflowpod.go
@@ -1063,6 +1063,16 @@ func addOutputArtifactsVolumes(pod *apiv1.Pod, tmpl *wfv1.Template) {
 			if util.IsWindowsUNCPath(mnt.MountPath, tmpl) {
 				continue
 			}
+			isConfigMapVolume := false
+			for _, vol := range pod.Spec.Volumes {
+				if vol.Name == mnt.Name && vol.ConfigMap != nil {
+					isConfigMapVolume = true
+					break
+				}
+			}
+			if isConfigMapVolume {
+				continue
+			}
 			mnt.MountPath = filepath.Join(common.ExecutorMainFilesystemDir, mnt.MountPath)
 			// ReadOnly is needed to be false for overlapping volume mounts
 			mnt.ReadOnly = false