Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(uv step): check self update result if self-update feat is available #1000

Merged

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Dec 10, 2024

What does this PR do

For the uv step, if the self-update feature is available, we should do the update and check its result.

cc @lucaspar

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC SteveLauC changed the title refactor: check self update result if self-update feat is available refactor(uv step): check self update result if self-update feat is available Dec 10, 2024
@SteveLauC
Copy link
Member Author

Thanks for reviewing!

@SteveLauC SteveLauC merged commit 8227890 into topgrade-rs:main Dec 10, 2024
12 checks passed
@SteveLauC SteveLauC deleted the refactor/do_not_ignore_self_update_err branch December 10, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants