fix: Executor::spawn()/output() should not use their _checked() variants

[SteveLauC]

What does this PR do

CommandExt::output_checked() returns Err() if the command fails, using it in Executor::output() will make its behavior different from std::process::Command::output().

The same applies to spawn() as well. Executor does not have a status() command.

These changes were made 2 years ago by @9999years, it would be great if we can have you here and take a look at this PR:)

Standards checklist

• The PR title is descriptive
• I have read CONTRIBUTING.md
• Optional: I have tested the code myself
• If this PR introduces new user-facing messages they are translated

For new steps

• Optional: Topgrade skips this step where needed
• Optional: The --dry-run option works with this step
• Optional: The --yes option works with this step if it is supported by
  the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

[9999years]

We might want to keep these for the rest of the codebase and do #[allow(clippy::disallowed_methods)] on the calls in src/executor.rs (where we have a reason to use the raw spawn method).

[SteveLauC]

Makes sense:)

[9999years]

This looks good! Thanks for the ping —I really love topgrade so I'm happy to review PRs like this. Thanks for all you do to maintain it!

[9999years]

BTW, since I wrote the CommandExt trait used in topgrade, I've expanded and polished it into the command_error crate (which builds on the utf_command crate); we might consider switching to that at some point.

[SteveLauC]

BTW, since I wrote the CommandExt trait used in topgrade, I've expanded and polished it into the command_error crate (which builds on the utf_command crate); we might consider switching to that at some point.

Neat! Topgrade should switch to it!