Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip needrestart when using nala on debian-based distro #548

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Sep 14, 2023

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Closes #547

@SteveLauC
Copy link
Member Author

cc @RayJW, here is a build with this patch included , you can test it: https://github.com/SteveLauC/topgrade/releases/tag/needrestart-debian-nala

@RayJW
Copy link

RayJW commented Sep 14, 2023

I just tested it and it works great, thanks! I just realized that the same should be done for DNF but if I understood the code correctly, then that is already the case, right?

@SteveLauC
Copy link
Member Author

I just realized that the same should be done for DNF but if I understood the code correctly, then that is already the case, right?

Yep, RedHat distros are already handled

@SteveLauC SteveLauC merged commit 06a6b7a into topgrade-rs:master Sep 14, 2023
8 checks passed
@SteveLauC SteveLauC deleted the nala branch September 14, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The needrestart step should be skipped when nala is the apt frontend.
2 participants