Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(app.yml): new language fr #969

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Gudsfile
Copy link
Contributor

What does this PR do

Translated topgrade to fr.

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@Gudsfile Gudsfile force-pushed the i18n-add-language-fr branch 2 times, most recently from 86e2dd5 to 14a694c Compare October 27, 2024 10:43
@SteveLauC
Copy link
Member

Thanks for doing it!

@Gudsfile Gudsfile force-pushed the i18n-add-language-fr branch 2 times, most recently from 00602ed to e6e5d35 Compare October 28, 2024 20:46
@Gudsfile Gudsfile marked this pull request as ready for review October 28, 2024 20:50
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, found some tiny errors.

locales/app.yml Outdated Show resolved Hide resolved
locales/app.yml Outdated Show resolved Hide resolved
locales/app.yml Outdated Show resolved Hide resolved
Apply suggestions from code review

Co-authored-by: SteveLauC <[email protected]>
@Gudsfile Gudsfile force-pushed the i18n-add-language-fr branch from 85f3be6 to d33ef25 Compare October 29, 2024 08:27
@Gudsfile
Copy link
Contributor Author

Thanks for the PR, found some tiny errors.

Oh! Sorry for the errors. Thank you for your vigilance and suggestions.
It's been corrected.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SteveLauC SteveLauC merged commit 98ec13f into topgrade-rs:main Oct 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants