-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime_mappings support #887
base: master
Are you sure you want to change the base?
Add runtime_mappings support #887
Conversation
6a7cf31
to
3a81990
Compare
@TakuyaKurimoto Thanks for the PR! unfortunately I'm not familiar with the runtime mappings features, let me learn it and get back to you. |
OK! |
@konalegi |
@TakuyaKurimoto Sorry, was extremely busy. Is this PR still relevant? |
@konalegi |
Cool, can you rebase and push latest changes so I can run CI? |
3a81990
to
dd04e71
Compare
@konalegi |
Everything is passing, let me get familiar with the topic, and I'll merge it. |
Thank you! |
@TakuyaKurimoto looks good 👍 Although could you please add a couple of lines into documentation about this feature, no extensive doc is needed, just an example + reference to elastic doc, so people know that this feature exists. |
@konalegi |
@TakuyaKurimoto Actually I'm about README.md |
dd04e71
to
693f689
Compare
693f689
to
ef5d800
Compare
@konalegi |
Hello.
One time I wanted to use runtime_mappings, but in chewy I had to write the following code because chewy does not support runtime_mappings .
This is a bit inconvenient, so I was wondering if you could support runtime_mappings in chewy as well?
If this code is merged, it will be possible to do something like the code below
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).