Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable translation of footnotes #64

Closed

Conversation

jhonatan-lopes
Copy link
Contributor

Adds TranslatableMixin to the Footnote model to allow it to be translatable.

Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of initial notes in tests

tests/test/test_translation.py Outdated Show resolved Hide resolved
tests/test/test_translation.py Outdated Show resolved Hide resolved
tests/test/test_translation.py Show resolved Hide resolved
tests/test/test_translation.py Outdated Show resolved Hide resolved
Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions for tidy up / docs.

The rest makes sense to me

@@ -11,6 +12,10 @@
path("django-admin/", admin.site.urls),
path("admin/", include(wagtailadmin_urls)),
path("documents/", include(wagtaildocs_urls)),
]

urlpatterns += i18n_patterns(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to add a note, or even section in the README about usage with translation

wagtail_footnotes/models.py Show resolved Hide resolved
@zerolab
Copy link
Member

zerolab commented May 17, 2024

Continuing in #69

@zerolab zerolab closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants