Skip to content

Commit

Permalink
header: use errors.Is
Browse files Browse the repository at this point in the history
  • Loading branch information
tormoder committed Jan 23, 2023
1 parent d72044a commit 14e5de2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions header.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package fit
import (
"bytes"
"encoding/binary"
"errors"
"fmt"
"io"

Expand Down Expand Up @@ -44,7 +45,7 @@ func NewHeader(v ProtocolVersion, crc bool) Header {
func (d *decoder) decodeHeader() error {
err := binary.Read(d.r, le, &d.h.Size)
if err != nil {
if err == io.EOF {
if errors.Is(err, io.EOF) {
return errReadSize
}
return ioError{"reading size", err}
Expand All @@ -55,7 +56,7 @@ func (d *decoder) decodeHeader() error {

_, err = io.ReadFull(d.r, d.tmp[:d.h.Size-1])
if err != nil {
if err == io.EOF || err == io.ErrUnexpectedEOF {
if errors.Is(err, io.EOF) || errors.Is(err, io.ErrUnexpectedEOF) {
return errReadData
}
return ioError{"reading data", err}
Expand Down
3 changes: 2 additions & 1 deletion header_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package fit

import (
"bytes"
"errors"
"testing"

"github.com/tormoder/fit/dyncrc16"
Expand Down Expand Up @@ -88,7 +89,7 @@ func TestDecodeHeader(t *testing.T) {
dec.r = bytes.NewReader(dht.in)
dec.crc = dyncrc16.New()
err := dec.decodeHeader()
if err != dht.err {
if !errors.Is(err, dht.err) {
t.Errorf("%d: got error: %v, want: %v", i, err, dht.err)
continue
}
Expand Down

0 comments on commit 14e5de2

Please sign in to comment.