cache the results of inputPropChanged

torsten-simon · Nov 19, 2017 · 34397ac · 34397ac
1 parent 12033e8
commit 34397ac
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/modules/infinite-scroll.directive.ts b/src/modules/infinite-scroll.directive.ts
@@ -46,11 +46,14 @@ export class InfiniteScrollDirective
   }
 
   ngOnChanges({ infiniteScrollContainer, infiniteScrollDisabled }: SimpleChanges) {
-    if (inputPropChanged(infiniteScrollContainer) || inputPropChanged(infiniteScrollDisabled)) {
+    var containerChanged: boolean = inputPropChanged(infiniteScrollContainer);
+    var disabledChanged: boolean = inputPropChanged(infiniteScrollDisabled)
+
+    if (containerChanged || disabledChanged) {
       this.destroyScroller();
 
-      if ((!inputPropChanged(infiniteScrollDisabled) && !this.infiniteScrollDisabled) ||
-          (inputPropChanged(infiniteScrollDisabled) && !infiniteScrollDisabled.currentValue)) {
+      if ((!disabledChanged && !this.infiniteScrollDisabled) ||
+          (disabledChanged && !infiniteScrollDisabled.currentValue)) {
         this.setup();
       }
     }