Skip to content

Commit

Permalink
attempt to fix orizens#147 (no an NgModule)
Browse files Browse the repository at this point in the history
  • Loading branch information
orizens committed Apr 13, 2017
1 parent 4faebca commit 808292a
Show file tree
Hide file tree
Showing 8 changed files with 54 additions and 69 deletions.
41 changes: 31 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,34 @@
## Angular library starter Changelog
## v 0.4.1 (2017/04/13)
* Fixes #147 - (__InfiniteScrollModule is not an NgModule__)

<a name="Mar 25, 2017"></a>
### Mar 25, 2017
* Upgrade to Angular 4 configuration
## v 0.4.0 (2017/04/12)
* Added Angular 4 support
* New starter code base ([based on angular-library-starter](https://github.com/robisim74/angular-library-starter))

<a name="Mar 6, 2017"></a>
### Mar 6, 2017
* Add _compodoc_ for generating documentation
## v 0.3.3 (2017/03/01)

### Updates
* reverted the fix of #126

## v 0.3.2 (2017/03/01)

### Updates
* fixes [#126](https://github.com/orizens/angular2-infinite-scroll/issues/126)

## v 0.3.1 (2017/02/15)

### Updates
* added custom scrollable container from [#108](https://github.com/orizens/angular2-infinite-scroll/pull/108/files)

## v 0.3.0 (2017/01/31)

### Updates
* refactored infinite scroller to smaller modules with composition
* added "models" - includes interfaces for development

## v 0.2.9 (2017/01/13)

### Updates
* added changelog.md
* ([refactor(scroll): replaces throttle with debounce](https://github.com/orizens/angular2-infinite-scroll/pull/82))

<a name="Feb 5, 2017"></a>
### Feb 5, 2017
* Create library
2 changes: 1 addition & 1 deletion index.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export * from './public_api';
import { InfiniteScrollModule } from './src/ngx-infinite-scroll';
23 changes: 12 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-infinite-scroll",
"version": "0.4.0",
"version": "0.4.1",
"description": "Build an Angular library compatible with AoT compilation and Tree shaking",
"main": "./bundles/ngx-infinite-scroll.umd.js",
"module": "./modules/ngx-infinite-scroll.es5.js",
Expand All @@ -12,10 +12,11 @@
"publish-lib": "npm publish ./dist",
"publish:beta": "npm publish --tag beta ./dist",
"compodoc": "compodoc -p tsconfig.json",
"compodoc-serve": "compodoc -s"
"compodoc-serve": "compodoc -s",
"transpile": "ngc -p ./tsconfig.json"
},
"typings": "./index.d.ts",
"author": "",
"author": "Oren Farhi (orizens.com)",
"repository": {
"type": "git",
"url": "https://github.com/orizens/ngx-infinite-scroll.git"
Expand All @@ -35,14 +36,14 @@
"@angular/core": ">= 4.0.0"
},
"devDependencies": {
"@angular/common": "4.0.0",
"@angular/compiler": "4.0.0",
"@angular/compiler-cli": "4.0.0",
"@angular/core": "4.0.0",
"@angular/platform-browser": "4.0.0",
"@angular/platform-browser-dynamic": "4.0.0",
"@angular/platform-server": "4.0.0",
"@angular/animations": "4.0.0",
"@angular/common": "^4.0.0",
"@angular/compiler": "^4.0.0",
"@angular/compiler-cli": "^4.0.0",
"@angular/core": "^4.0.0",
"@angular/platform-browser": "^4.0.0",
"@angular/platform-browser-dynamic": "^4.0.0",
"@angular/platform-server": "^4.0.0",
"@angular/animations": "^4.0.0",
"@types/jasmine": "2.5.46",
"@types/node": "7.0.10",
"codelyzer": "3.0.0-beta.4",
Expand Down
3 changes: 2 additions & 1 deletion public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@
/**
* Entry point for all public APIs of the package.
*/
export * from './src/ngx-infinite-scroll';
export { InfiniteScrollModule } from './src/modules/ngx-infinite-scroll.module';

37 changes: 0 additions & 37 deletions src/modules/arithmetic-module.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import { ScrollRegister } from '../services/scroll-register';
import { ScrollResolver } from '../services/scroll-resolver';

@NgModule({
imports: [],
declarations: [InfiniteScroll],
exports: [InfiniteScroll],
imports: [],
providers: [
AxisResolverFactory,
PositionResolverFactory,
Expand Down
10 changes: 5 additions & 5 deletions src/ngx-infinite-scroll.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
// Public classes.
// export { SumService } from './services/sum-service';
// export { ArithmeticModule } from './modules/arithmetic-module';

export { InfiniteScroll } from './modules/infinite-scroll';
export { PositionResolver, PositionResolverFactory } from './services/position-resolver';
export { AxisResolver, AxisResolverFactory } from './services/axis-resolver';
export { ScrollRegister } from './services/scroll-register';
export { ScrollResolver } from './services/scroll-resolver';
export { InfiniteScrollModule } from './modules';
export { InfiniteScrollModule } from './modules/ngx-infinite-scroll.module';

export { ContainerRef, InfiniteScrollEvent, PositionElements, PositionStats, ScrollStats, ScrollerConfig} from './models';
export {
ContainerRef, InfiniteScrollEvent,
PositionElements, PositionStats, ScrollStats, ScrollerConfig
} from './models';
5 changes: 2 additions & 3 deletions tsconfig-build.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@
]
},
"files": [
"public_api.ts",
"node_modules/zone.js/dist/zone.js.d.ts"
"public_api.ts"
],
"angularCompilerOptions": {
"skipTemplateCodegen": true,
"annotateForClosureCompiler": true,
"strictMetadataEmit": true,
"flatModuleOutFile": "index.js",
"flatModuleId": "angular-library-starter"
"flatModuleId": "ngx-infinite-scroll"
}
}

0 comments on commit 808292a

Please sign in to comment.