Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/UI #2388

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Fix/UI #2388

merged 2 commits into from
Feb 18, 2025

Conversation

tanguyenvn
Copy link
Contributor

Motivation and Context

NFT Trump cards users are using Torus Wallet which has some UI bugs.

Description

Icons of passwordless login type and user profile are not showing correctly
image
We should fix this

How has this been tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.08%. Comparing base (b788be8) to head (4668bbf).
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2388      +/-   ##
===========================================
- Coverage    62.15%   62.08%   -0.08%     
===========================================
  Files           48       48              
  Lines         4281     4281              
===========================================
- Hits          2661     2658       -3     
- Misses        1620     1623       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanguyenvn tanguyenvn self-assigned this Feb 18, 2025
Copy link
Contributor

@lionellbriones lionellbriones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tanguyenvn tanguyenvn merged commit 68d49c0 into develop Feb 18, 2025
3 checks passed
@tanguyenvn tanguyenvn deleted the fix/ui branch February 18, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants