feat(toFormData): Add toFormData
#726
Open
+1,013
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lukaszkowalik2
changed the title
toFormData
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 99.74% 99.71% -0.04%
==========================================
Files 311 312 +1
Lines 2791 2838 +47
Branches 830 857 +27
==========================================
+ Hits 2784 2830 +46
- Misses 7 8 +1
|
|
Let me review this weekend :) |
|
Hold off on reviewing this for now. I'm going to refactor it a bit and add some configuration to it. Then I'll make another PR after you (hopefully) accept this one. After that, I'll add a function called fromFormData to convert FormData to an object. |
|
@raon0211 I’ve added the changes I wanted, so you can go ahead with the review whenever you’re ready. Thanks! 😃 |
|
Thanks! This is a new function so I might need some time to think. Let me review this in a week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve added the
toFormDatafunction to the library. The initial idea was inspired by the object-to-formdata project. I’ve expanded on that project by adding support for additional JavaScript data types likeBigIntandSymbol.Key Additions:
BigIntvalues to strings, ensuring they can be included inFormData.Symbolvalues will throw an error, as they cannot be serialized.Additionally, I attempted to make the function more type-safe, but due to the limitations outlined in this TypeScript issue, it’s not yet possible to implement a fully generic type-safe version of
FormData.Request for Help:
File: I'm having trouble getting the tests involvingFileto work in a CI environment. Any guidance on how to resolve this would be greatly appreciated!Thanks in advance to anyone who can assist!