Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add): Add add function #825

Merged
merged 8 commits into from
Nov 23, 2024
Merged

feat(add): Add add function #825

merged 8 commits into from
Nov 23, 2024

Conversation

kim-dongho
Copy link
Contributor

@kim-dongho kim-dongho commented Nov 14, 2024

Add add function

image

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 1:05pm

@raon0211
Copy link
Collaborator

Hello! :)

Thanks for adding the add function to our library! That said, I'm not entirely sure if this function is commonly used in actual JavaScript projects. We aim to include only major functions in our main library, if possible.

Would you be open to adding this function only to our compatibility library instead, for compatibility purposes?

@kim-dongho
Copy link
Contributor Author

@raon0211

Hello!

I agree that this function is not commonly used in standard JavaScript. I also agree with adding it to the compatibility library for compatibility purposes.

Thank you :)

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the add function to the compat directory. Thanks for opening the pull request and suggesting the changes :)

@raon0211 raon0211 merged commit 4e096f8 into toss:main Nov 23, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants