Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/(intersectionBy, differenceBy, differenceWith): should allow array with different element type. #836

Merged

Conversation

mass2527
Copy link
Contributor

I think #819 hasn’t been fixed yet.
intersectionBy, differenceWith, and differenceBy should also support arrays with different element types.

@mass2527 mass2527 requested a review from raon0211 as a code owner November 21, 2024 14:11
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 2:14pm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (a46d8c4) to head (e4e163b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         306      306           
  Lines        2743     2743           
  Branches      818      818           
=======================================
  Hits         2742     2742           
  Misses          1        1           
---- 🚨 Try these New Features:

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 3a619e5 into toss:main Nov 22, 2024
8 checks passed
@mass2527 mass2527 deleted the fix/support-different-types-in-array-functions branch November 22, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants