set mode of cache files to 0666 & ~umask, related to #147

toy · Apr 10, 2017 · dc0d44e · dc0d44e
1 parent 7d4ece5
commit dc0d44e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/image_optim/cache.rb b/lib/image_optim/cache.rb
@@ -34,6 +34,7 @@ def fetch(original)
       if optimized
         tmp = FSPath.temp_file_path(digest, @cache_dir)
         FileUtils.mv(optimized, tmp)
+        tmp.chmod(0o666 & ~File.umask)
         tmp.rename(cached)
         cached_path = CachePath.convert(cached)
 

diff --git a/spec/image_optim/cache_spec.rb b/spec/image_optim/cache_spec.rb
@@ -72,6 +72,9 @@
           expect(FileUtils).to receive(:mv).with(optimized, tmp_file)
           expect(tmp_file).to receive(:rename).with(cached)
 
+          allow(File).to receive(:umask).and_return(0o024)
+          expect(tmp_file).to receive(:chmod).with(0o642)
+
           expect(cache.fetch(original){ optimized }).to eq(cached)
         end