オブジェクトストレージの実装 #17
Merged
オブジェクトストレージの実装 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Image(年賀状のスタンプ)は多分ファイル名が必要になるからいるかも (追記)いらんか |
H1rono
reviewed
Dec 16, 2023
Comment on lines
+27
to
+29
| pub fn new(bucket: &Bucket) -> Self { | ||
| Self(bucket.clone()) | ||
| } |
There was a problem hiding this comment.
CardRepositoryConfigと同じようなやつが欲しい
struct Config {
pub bucket_name: String,
pub region: String,
pub credentials: String, // ?
}
H1rono
reviewed
Dec 16, 2023
repository/src/image.rs
Outdated
|
|
||
| #[async_trait::async_trait] | ||
| pub trait ImageRepository { | ||
| async fn save_png(&self, card_id: Uuid, content: &[u8]) -> Result<(), RepositoryError>; |
There was a problem hiding this comment.
bytes::BytesがDeref<Target=[u8]>持ってるのでそちらを
repository/src/image.rs
Outdated
| &self, | ||
| id: Uuid, | ||
| mime_type: &str, | ||
| content: &[u8], |
repository/src/image.rs
Outdated
| } | ||
| async fn delete_svg(&self, id: Uuid) -> Result<(), RepositoryError> { | ||
| let bucket = &self.0; | ||
| let key = id.to_string() + ".svg"; |
There was a problem hiding this comment.
uuid::UuidはDisplay実装してるのでformat!使えばちょっといい感じになるかも？まあこのままでも全然
| @@ -103,7 +101,7 @@ impl CardRepository for CardRepositoryImpl { | |||
| } | |||
| } | |||
|
|
|||
| async fn save_card(&self, params: &SaveCardParams) -> Result<(), DbErr> { | |||
| async fn save_card(&self, params: &SaveCardParams) -> Result<(), RepositoryError> { | |||
| // TODO: 画像の保存 | |||
repository/src/error.rs
Outdated
Comment on lines
14
to
15
| #[error("NotFound")] | ||
| NotFound, |
repository/src/image.rs
Outdated
| match image { | ||
| Ok(x) => Ok(Some(( | ||
| x.headers().get("content-type").unwrap().to_string(), | ||
| x.to_vec(), |
There was a problem hiding this comment.
バイナリデータはbytes::Bytesで揃えたいので、Bytes::from(x.to_vec())とかで 🙏
|
書き忘れてた、compose.yamlにs3のモックが欲しい |
|
bucketが自動で作成されないので手動で作成する |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
書いてから思ったけどmysqlにid保存する必要なかったかも