Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handlerからmainを分離する #18

Merged
merged 2 commits into from
Dec 16, 2023
Merged

handlerからmainを分離する #18

merged 2 commits into from
Dec 16, 2023

Conversation

zer0-star
Copy link
Contributor

No description provided.

@zer0-star zer0-star marked this pull request as draft December 16, 2023 12:31
@zer0-star zer0-star requested a review from H1rono December 16, 2023 12:32
@H1rono
Copy link
Member

H1rono commented Dec 16, 2023

https://github.com/traP-jp/h23w_01-backend/blob/a86d70eae854b0fb555cfb5592e70899fbd31784/handler/src/main.rs

ここのfn rocketstatic CORS_CONFIGをentrypointに移して欲しいです

@H1rono
Copy link
Member

H1rono commented Dec 16, 2023

#[launch]
async fn rocket() -> _ {

で、このlaunchtokio::mainに差し替えていい感じに動くようにしてほしいです
特にctrl-cを押して正常に終了できるか(graceful shutdown)を確認して欲しい、今はできる

@H1rono
Copy link
Member

H1rono commented Dec 16, 2023

@zer0-star zer0-star marked this pull request as ready for review December 16, 2023 13:12
@zer0-star zer0-star merged commit 5cfe6a2 into main Dec 16, 2023
2 checks passed
@zer0-star zer0-star deleted the split-main branch December 16, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants