This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
figmaからもにょもにょっと実装 #229
Open
figmaからもにょもにょっと実装 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehm8128
reviewed
Aug 20, 2023
There was a problem hiding this comment.
border-radiusが違うのとか気になるので、BaseDateInputもいじってほしいです:pray:
| padding: 0.375rem 1rem; | ||
| height: 2.25rem; | ||
| min-width: 4rem; | ||
| font-size: 1rem; |
There was a problem hiding this comment.
font-sizeはデフォルトで1remなので書かなくてもよさそうです
| border-radius: 0.375rem; | ||
| padding: 0.375rem 1rem; | ||
| height: 2.25rem; | ||
| min-width: 4rem; |
There was a problem hiding this comment.
min-widthいじった影響で中身ずれちゃってそうです
justify-content: center入れると解決しそう
| display: flex; | ||
| padding: 0.375rem 0.625rem; | ||
| align-items: center; | ||
| flex: 1 0 0; |
There was a problem hiding this comment.
これ入れたことでユーザー名と説明文のinputが同じ長さになってそう(元は説明文の方が長かった)だけど、これは意図した変更ですか？
There was a problem hiding this comment.
ここplaceholderが表示しきれてない(多分変更前もそうだった)からコンポーネント使う側でwidth指定するのがよさそう
| height: 2.5rem; | ||
| font-size: 0.875rem; | ||
| font-size: 1.25rem; | ||
| border: 1px solid $color-secondary; |
There was a problem hiding this comment.
コメントパネルの方にはborderつけないようにみたいなこと言ってなかったっけ、このままでOK?
OKならFigmaの方直しておいてほしいです
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185